Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve const-correctness #7

Open
elfring opened this issue May 1, 2014 · 3 comments
Open

Improve const-correctness #7

elfring opened this issue May 1, 2014 · 3 comments

Comments

@elfring
Copy link

elfring commented May 1, 2014

I suggest to add the key word "const" to the type specifiers for parameters like "filename" (functions "bsmap" and "dx_build").
Would you like to apply the advices from an article to more places in your source files?

@rchiossi
Copy link
Owner

rchiossi commented May 1, 2014

Those are welcome improvements. Can you sendo me a pull request with them?

@elfring
Copy link
Author

elfring commented May 1, 2014

I find that the status should be clarified a bit more for the member "filename" of the data structure "ByteStream". Would you like to store a modifiable string there?

@rchiossi
Copy link
Owner

rchiossi commented May 2, 2014

Not really. The filename should be set only once for each bytestream object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants