Added the possibility to define any route. #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
israelcolomer
force-pushed
the
ic/any-route
branch
from
9495df3
to
537853a
Compare
rchodava
approved these changes
Apr 7, 2017
| } | ||
|
|
||
| @Test | ||
| public void elsAnyRouteHonoredIfObservableReturned() { |
| /** | ||
| * @author Israel Colomer (israelcolomer@gmail.com) | ||
| */ | ||
| public class ElseBuilderTest { |
There was a problem hiding this comment.
It's a bit weird to have tests for ElseBuilder - the interface is separate from RouteBuilder mostly to have the fluent chaining make sense. These tests should be in RouteBuilderTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.