Allow datamill client to perform PATCH requests #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reimplemented client request core method to rely on httpclient rather than JDK UrlConnection, as the latter doesn't allow certain Http methods (i.e. PATCH). Adapted tests to new implementation.
| URIBuilder uriBuilder = new URIBuilder(); | ||
|
|
||
|
|
||
| int firstSlash = uri.indexOf('/'); |
There was a problem hiding this comment.
Not sure I understand why you are doing all the string manipulation here - I think just create a URI straight from the string and let the URI implementations deal with it? Also, "theURI" and "anURI" are not good names
There was a problem hiding this comment.
I dunno what I was thinking sorry..late hours programming 😁
Applied review comments.
Applied more comments, refactored and cleanup.
Mock execute method in client tests so they run faster and don't send requests (which arent checked anyway)
(Hopefully) fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplemented client request core method to rely on httpclient rather than JDK UrlConnection, as the latter doesn't allow certain Http methods (i.e. PATCH).
Adapted tests to new implementation.