Undo refactoring of http steps, and add capability of performing call… #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s with streaming responses.
rchodava
approved these changes
Nov 2, 2016
| @@ -108,6 +142,19 @@ public void assertResponseAndHeaders(int statusCode, Map<String, String> headers | |||
| compareHeaders(headers, storedResponse.headers()); | |||
| } | |||
|
|
|||
| void compareHeaders(Map<String, String> expectedHeaders, Multimap<String, String> actualHeaders) { | |||
There was a problem hiding this comment.
Being used in a test, reason why it's only package protected
| return (Map<String, String>) propertyStore.get(HEADER_KEY); | ||
| } | ||
|
|
||
| public Observable<JsonObject> makeStreamingCall(Method method, String uri, Map<String, String> headers) { |
There was a problem hiding this comment.
Maybe include Json in this name? makeStreamingJsonCall
|
Changes Unknown when pulling aaa0d16 on ic/http-steps-streaming-call into * on master*. |
|
Changes Unknown when pulling 69c697a on ic/http-steps-streaming-call into * on master*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s with streaming responses.