bugfix: fixed wrong calculation of hash length #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchouinard
added a commit
that referenced
this pull request
Nov 22, 2015
bugfix: fixed wrong calculation of hash length
rchouinard
added a commit
that referenced
this pull request
Nov 22, 2015
This commit looks bigger than it is. Most of the changes are cosmetic, although the function body has changed to better simulate the error conditions and messages of the built-in function found in PHP >=5.5. Other changes are listed below: - Add LICENSE.md file - Update phpunit development dependency - Update tests to check for proper error handling - Update tests to check for the conditions of PR #1 - Add docblocks compatible with the built-in function - Minor changes to git and travis configurations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library is really cool, i discovered just one issue:
If you call
hash_pbkdf2with default raw_output = false, than the resulting hash is not compatible to the hash created with the internal function hash_pbkdf2 in newer php, because you calculate the hash length always with raw_output = true.I stumbled over this issue after creating a bunch of hashes using php-5.6.1 and wanting to use those hashes on an older machine having your compat library installed.