Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle UTF-8 BOM #106

Closed
JamieMagee opened this issue Jun 14, 2022 · 3 comments
Closed

Handle UTF-8 BOM #106

JamieMagee opened this issue Jun 14, 2022 · 3 comments
Assignees
@rcjsuen
Labels
bug

Comments

@JamieMagee
Copy link

When a Dockerfile begins with a UTF-8 BOM, the first instruction is not parsed correctly. This causes FROM statements to be parsed as generic Instructions instead of From

I think Visual Studio adds UTF-8 BOMs by default.
@rcjsuen rcjsuen self-assigned this Aug 2, 2022
@rcjsuen
Copy link
Owner

rcjsuen commented Aug 2, 2022

@JamieMagee Thank you for your bug report and apologies for not responding to this earlier. I have a fix but will need to confirm the behaviour of how offsets are handled in the language server protocol if a BOM is found.

@rcjsuen rcjsuen closed this as completed in 886187b Aug 3, 2022
rcjsuen added a commit that referenced this issue Aug 4, 2022
@rcjsuen
Fix #106 Update CHANGELOG.md with a link to the issue
479065c 
Signed-off-by: Remy Suen <remy.suen@gmail.com>
@rcjsuen
Copy link
Owner

rcjsuen commented Aug 4, 2022

@JamieMagee I have just released 0.5.0 which includes a fix for this. Please let me know if it resolves your issue.

@rcjsuen rcjsuen added the bug label Aug 4, 2022
@rcjsuen rcjsuen mentioned this issue Aug 4, 2022
Closed
@JamieMagee
Copy link
Author

Yep, this solves my issue. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rcjsuen rcjsuen

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JamieMagee @rcjsuen