Docker image name incorrectly identified as registry in FROM

[daimor]

Docker hub has images from verified publishers, and such image names starts with store/
For example
store/intersystems/iris-community link
store/intersystems/irishealth link
store/splunk/universalforwarder link
on so on

At the moment parser recognizes store as registry but in this case it is just a part of image name

To be solved for microsoft/vscode-docker#1337

[rcjsuen]

@daimor This opens up an interesting can of worms as you could have any arbitrary word in front of the image's name and have that be a Docker registry given your local DNS settings or whatever. I wonder how Docker implements this on their end. Could they be hardcoding the word store in their handling of Dockerfiles?

[daimor]

Well, I found this code, which used by docker-cli

// splitDockerDomain splits a repository name to domain and remotename string.
// If no valid domain is found, the default domain is used. Repository name
// needs to be already validated before.
func splitDockerDomain(name string) (domain, remainder string) {
	i := strings.IndexRune(name, '/')
	if i == -1 || (!strings.ContainsAny(name[:i], ".:") && name[:i] != "localhost") {
		domain, remainder = defaultDomain, name
	} else {
		domain, remainder = name[:i], name[i+1:]
	}
	if domain == legacyDefaultDomain {
		domain = defaultDomain
	}
	if domain == defaultDomain && !strings.ContainsRune(remainder, '/') {
		remainder = officialRepoName + "/" + remainder
	}
	return
}

So, it actually means, that localhost is hardcoded, and any domain name should contain dots . or colon :
if no localhost and does not contains ., : it is just image name.

[rcjsuen]

@daimor Well then. You learn something new every day as I always like to say...

Thanks for digging this up!

[rcjsuen]

import { DockerfileParser, From } from './main';
const dockerfile = DockerfileParser.parse("FROM store/base/image");
const from = (dockerfile.getInstructions()[0]) as From;
console.log(from.getImageName());

base/image

We should get store/base/image instead.

[rcjsuen]

@daimor Thanks for the bug report. Have a great weekend!