Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline argument with an embedded comment with a quote causes semantic tokens calculation to enter an infinite loop #110

Closed
rcjsuen opened this issue May 28, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented May 28, 2023

RUN echo "test" &\
# a'b
echo "test2"
const lib = require("dockerfile-language-service");
const service = lib.DockerfileLanguageServiceFactory.createLanguageService();
const tokens = service.computeSemanticTokens(`RUN echo "test" &\\\n# a'b\necho "test2"`);
console.log(tokens);
../dockerfile-language-service/lib/dockerSemanticTokens.js:535
                var intermediateRange = {
                                        ^

RangeError: Maximum call stack size exceeded
    at DockerSemanticTokens.createToken (../dockerfile-language-service/lib/dockerSemanticTokens.js:535:41)
    at DockerSemanticTokens.createToken (../dockerfile-language-service/lib/dockerSemanticTokens.js:539:22)
    at DockerSemanticTokens.createToken (../dockerfile-language-service/lib/dockerSemanticTokens.js:539:22)
    at DockerSemanticTokens.createToken (../dockerfile-language-service/lib/dockerSemanticTokens.js:539:22)
    at DockerSemanticTokens.createToken (../dockerfile-language-service/lib/dockerSemanticTokens.js:539:22)
    at DockerSemanticTokens.createToken (../dockerfile-language-service/lib/dockerSemanticTokens.js:539:22)
    at DockerSemanticTokens.createToken (../dockerfile-language-service/lib/dockerSemanticTokens.js:539:22)
    at DockerSemanticTokens.createToken (../dockerfile-language-service/lib/dockerSemanticTokens.js:539:22)
    at DockerSemanticTokens.createToken (../dockerfile-language-service/lib/dockerSemanticTokens.js:539:22)
    at DockerSemanticTokens.createToken (../dockerfile-language-service/lib/dockerSemanticTokens.js:539:22)
@rcjsuen rcjsuen added the bug Something isn't working label May 28, 2023
@rcjsuen rcjsuen changed the title Infinite loop for semantic tokens when ampersand (&) is followed by a backslash (\) Multiline argument with an embedded comment with a quote causes semantic tokens calculation to enter an infinite loop May 28, 2023
@rcjsuen rcjsuen self-assigned this May 28, 2023
rcjsuen added a commit that referenced this issue May 28, 2023
Signed-off-by: Remy Suen <remy.suen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant