Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag double decimals in a HEALTHCHECK duration flag as an error #25

Closed
rcjsuen opened this issue Mar 8, 2018 · 0 comments
Closed

Flag double decimals in a HEALTHCHECK duration flag as an error #25

rcjsuen opened this issue Mar 8, 2018 · 0 comments
Assignees
@rcjsuen
Labels
enhancement

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Mar 8, 2018 

FROM alpine
HEALTHCHECK --timeout=5..5s CMD ls
$ docker build .
Sending build context to Docker daemon  1.695MB
Error response from daemon: Dockerfile parse error line 2: time: missing unit in duration 5..5s

$  docker run -v `pwd`/Dockerfile:/Dockerfile rcjsuen/dockerfile-utils lint /Dockerfile
$
@rcjsuen rcjsuen self-assigned this Mar 8, 2018
@rcjsuen rcjsuen closed this as completed in 070a9fd Mar 8, 2018
rcjsuen added a commit that referenced this issue Mar 9, 2018
@rcjsuen
Fix #25 Add tests for interval and start-period flags
a280154 
Signed-off-by: Remy Suen <remy.suen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rcjsuen rcjsuen

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rcjsuen