Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUN instructions with a single flag should raise an error #76

Closed
rcjsuen opened this issue Apr 2, 2020 · 0 comments
Closed

RUN instructions with a single flag should raise an error #76

rcjsuen opened this issue Apr 2, 2020 · 0 comments
Assignees

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Apr 2, 2020

FROM scratch
RUN --x=y
$ docker build .
Sending build context to Docker daemon  38.15MB
Error response from daemon: Dockerfile parse error line 2: Unknown flag: x
$ docker run -v `pwd`/Dockerfile:/Dockerfile rcjsuen/dockerfile-utils lint /Dockerfile
$ 

The error is a bit difficult to mirror given that RUN instructions have various experimental flags in BuildKit at the moment. We could at least flag this instruction as missing an argument as it does.

@rcjsuen rcjsuen added the bug label Apr 2, 2020
@rcjsuen rcjsuen self-assigned this Apr 2, 2020
@rcjsuen rcjsuen added enhancement and removed bug labels Apr 2, 2020
@rcjsuen rcjsuen changed the title RUN instructions with a single flag passes the parser RUN instructions with a single flag should raise an error Apr 2, 2020
@rcjsuen rcjsuen closed this as completed in b6880b1 Apr 2, 2020
rcjsuen added a commit that referenced this issue Apr 2, 2020
Signed-off-by: Remy Suen <remy.suen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant