Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support EXPOSE with SCTP protocol #51

Merged
merged 1 commit into from
Aug 16, 2018
Merged

Support EXPOSE with SCTP protocol #51

merged 1 commit into from
Aug 16, 2018

Conversation

jameswmcnab
Copy link
Contributor

Docker 18.03 added support for exposing SCTP ports for a container

This PR updates the validator to recognise EXPOSE 8080/sctp as valid.

Please let me know if I've missed anything.

@coveralls
Copy link

coveralls commented Aug 16, 2018

Coverage Status

Coverage increased (+0.001%) to 98.446% when pulling 120ff0b on jameswmcnab:sctp-protocol into e10197f on rcjsuen:master.

@rcjsuen
Copy link
Owner

rcjsuen commented Aug 16, 2018

Hi, @jameswmcnab. Thank you very much for your pull request.

The code itself looks good and sound! For stylistic reasons, please do the following (by amending your commit and then force pushing up to your branch):

  1. Add a note to the CHANGELOG.md under the "Added" section of the currently "Unreleased" bit at the top mentioning that this fixes Add support for SCTP in EXPOSE instruction #52. You can look at the many other entries in the changelog to get a feel of how I write these one-liners and the rough format it's in.
  2. Amend your commit message to include Fix #52 in the beginning of the commit message.
  3. In addition to 2, when amending your commit please also use -s so that we can get a Signed-off-by footer.

Thank you for your time and understanding!

@rcjsuen
Copy link
Owner

rcjsuen commented Aug 16, 2018

@jameswmcnab And, and I also forgot to mention to please update the bin/dockerfile-utils file.

function printVersion() {
const package = require("../package.json");
console.log("dockerfile-utils version " + package.version + " (supports Docker CE 17.09)");
}

Please change the above function to print out Docker CE 18.03 instead of Docker CE 17.09. Thanks!

Signed-off-by: James William McNab <james@jameswmcnab.com>
@jameswmcnab
Copy link
Contributor Author

jameswmcnab commented Aug 16, 2018

@rcjsuen Thanks! I've made the requested changes.

@rcjsuen rcjsuen merged commit a7aa06b into rcjsuen:master Aug 16, 2018
@rcjsuen
Copy link
Owner

rcjsuen commented Aug 16, 2018

@jameswmcnab Thank you for the quick turnaround and your wonderful contribution!

@jameswmcnab jameswmcnab deleted the sctp-protocol branch August 16, 2018 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants