Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple pub sub test #113

Merged
merged 2 commits into from
May 20, 2022
Merged

Add simple pub sub test #113

merged 2 commits into from
May 20, 2022

Conversation

s-hosoai
Copy link
Contributor

リファクタリング前の最低限の動作確認用に簡易なテストを追加しました。

@takasehideki
Copy link
Member

mix format で落ちちゃってますね,,, 修正 commit をお願いします.
https://github.com/rclex/rclex/runs/6521367553?check_suite_focus=true

ここのポリシーとしては GitHub Actions が通らないとmerge不可にしています.ただし Dashing ではこんな感じ #89 で通らなくなっているので,これは気にしなくてOKです.

@s-hosoai
Copy link
Contributor Author

おっとすみません、Format掛けてからPushするようにします。

Copy link
Member

@takasehideki takasehideki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@takasehideki takasehideki merged commit 3bfa12a into main May 20, 2022
@takasehideki takasehideki deleted the add_simple_pub_sub_test branch May 20, 2022 08:33
This was referenced May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants