Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude auto-generated files format #135

Merged
merged 1 commit into from
Jul 9, 2022

Conversation

pojiro
Copy link
Contributor

@pojiro pojiro commented Jul 8, 2022

自動生成されるROSのメッセージ型のコードのフォーマットを exclude する方法を知ったので、追加しました。

refs) https://groups.google.com/g/elixir-lang-core/c/T7MMg1OF1aI

デメリットは将来的にフォーマットをかけたくなった時に、なぜフォーマットされないのを調べるのにちょっと時間を要しそうなことです。

@pojiro pojiro marked this pull request as ready for review July 8, 2022 01:49
@takasehideki takasehideki merged commit 6de05dc into main Jul 9, 2022
@takasehideki takasehideki deleted the idea-ignore_generated_file_format-pojiro branch July 9, 2022 07:44
@takasehideki takasehideki restored the idea-ignore_generated_file_format-pojiro branch July 9, 2022 07:46
@takasehideki takasehideki deleted the idea-ignore_generated_file_format-pojiro branch July 9, 2022 07:46
@takasehideki
Copy link
Member

takasehideki commented Jul 9, 2022

デメリットは将来的にフォーマットをかけたくなった時に、なぜフォーマットされないのを調べるのにちょっと時間を要しそうなことです。

忘れっぽい将来の私のために #139 を残しておきました

takasehideki added a commit that referenced this pull request Sep 21, 2022
**Full Changelog**: v0.7.0...v0.7.1

* New Contributors: @pojiro 🎉
* New features:
  * Improve unit test environment on local dev machine by @pojiro in #131
* Code Improvements/Fixes:
  * Enrich doc and specs with the awesome contributions by @pojiro (e.g., in #121)
  * Enrich unit tests with the awesome contributions by @pojiro (e.g., in #136)
  * Improve credo config, .credo.exs by @pojiro in #120
  * exclude auto-generated files format by @pojiro in #135
  * refactor Rclex.ResourceServer.call_nifs_rcl_node_init/5 by @pojiro in #147
  * fix node name bug, when it attributes a namespace (and also fix #142) by @pojiro in #149
  * Remove KeepSub module which is unused (also fix dialyzer error) by @s-hosoai in #164
  * Improve README by @takasehideki in #171
* Bumps:
  * `credo` from 1.6.4 to 1.6.5 in #162
* Known issues to be addressed in the near future:
  * Lock `git_hooks` to 0.6.5 due to its issue in #138
  * Bump to Humble Hawksbill in #114
  * Release rcl nif resources when GerServer terminates in #160
* Note in this release:
  * After long consideration, we have decided to end the support for Dashing as the target environment 6ae367d
@takasehideki takasehideki mentioned this pull request Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants