Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Dialyzer on GitHub Actions (remove uncheck and ignore exit options) #165

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Enable Dialyzer on GitHub Actions (remove uncheck and ignore exit options) #165

merged 2 commits into from
Sep 21, 2022

Conversation

s-hosoai
Copy link
Contributor

No description provided.

@takasehideki takasehideki changed the title remove uncheck and ignore exit options Enable Dialyzer (remove uncheck and ignore exit options) Jul 19, 2022
@takasehideki takasehideki changed the title Enable Dialyzer (remove uncheck and ignore exit options) Enable Dialyzer on GitHub Actions (remove uncheck and ignore exit options) Jul 19, 2022
@takasehideki
Copy link
Member

おちた orz
https://github.com/rclex/rclex/runs/7404428455?check_suite_focus=true#step:7:154

@takasehideki
Copy link
Member

手元の最新版では mix dialyzer 通過しているのでOKと思い込みます

$ mix dialyzer 
make: Nothing to be done for 'all'.
Finding suitable PLTs
Checking PLT...
[:compiler, :elixir, :file_system, :kernel, :logger, :mix, :mix_test_watch, :stdlib]
PLT is up to date!
No :ignore_warnings opt specified in mix.exs and default does not exist.

Starting Dialyzer
[
  check_plt: false,
  init_plt: '/home/takase/rclex/rclex/_build/dev/dialyxir_erlang-24.1.5_elixir-1.12.3_deps-dev.plt',
  files: ['/home/takase/rclex/rclex/_build/dev/lib/rclex/ebin/Elixir.Rclex.GeometryMsgs.Msg.Twist.beam',
   '/home/takase/rclex/rclex/_build/dev/lib/rclex/ebin/Elixir.Rclex.GeometryMsgs.Msg.Vector3.beam',
   '/home/takase/rclex/rclex/_build/dev/lib/rclex/ebin/Elixir.Rclex.JobExecutor.beam',
   '/home/takase/rclex/rclex/_build/dev/lib/rclex/ebin/Elixir.Rclex.JobQueue.beam',
   '/home/takase/rclex/rclex/_build/dev/lib/rclex/ebin/Elixir.Rclex.Msg.beam',
   ...],
  warnings: [:unknown]
]
Total errors: 0, Skipped: 0, Unnecessary Skips: 0
done in 0m0.81s
done (passed successfully)

@takasehideki takasehideki merged commit 95d2fe0 into main Sep 21, 2022
@takasehideki takasehideki deleted the enable_mix_dialyzer branch September 21, 2022 08:28
@takasehideki takasehideki mentioned this pull request Sep 21, 2022
Closed
@takasehideki
Copy link
Member

fixed だけども #175 をしないといけなかった ;D

takasehideki added a commit that referenced this pull request Sep 22, 2022
@takasehideki
release v0.7.2
a88deba 
**Full Changelog**: v0.7.1...v0.7.2

* New features: none
* Code Improvements/Fixes:
  * change the recommended env and target versions for GitHub Actions CI by @takasehideki in #173
  * Enable Dialyzer on GitHub Actions (remove uncheck and ignore exit options) by @s-hosoai in #165
  * elinimate errors in `mix dialyzer` on GHA (fix #174) by @takasehideki in #175
* Bumps:
  * `dialyxir` from 1.1.0 to 1.2.0 in #166
  *  `ex_doc` from 0.28.4 to 0.28.5 in #168
  * `credo` from 1.6.5 to 1.6.7 by #169
* Known issues to be addressed in the near future:
  * Lock `git_hooks` to 0.6.5 due to its issue in #138
  * Bump to Humble Hawksbill in #114
  * Release rcl nif resources when GerServer terminates in #160
* Note in this release:
  * The recommended environment is changed to the following versions
    * Ubuntu 20.04.2 LTS (Focal Fossa)
    * ROS 2 [Foxy Fitzroy](https://docs.ros.org/en/foxy/Releases/Release-Foxy-Fitzroy.html)
    * Elixir 1.13.4-otp-25
    * Erlang/OTP 25.0.3
@takasehideki takasehideki mentioned this pull request Sep 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@s-hosoai @takasehideki