Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker command to mix test.watch section on README.md #177

Merged
merged 2 commits into from
Oct 4, 2022

Conversation

pojiro
Copy link
Contributor

@pojiro pojiro commented Oct 4, 2022

docker を使用した mix test.watch の実行方法を忘れてしまうため、READMEに追記しました。

@pojiro pojiro marked this pull request as ready for review October 4, 2022 02:57
Copy link
Member

@takasehideki takasehideki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

些細ですが suggestion です

README.md Outdated
@@ -100,7 +100,9 @@ docker compose down
`mix test.watch` is introduced to automatically run unit test `mix test` and code formatting `mix format` every time the source code was editted.

```
mix test.watch
$ mix test.watch
# run on docker by following
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# run on docker by following
# or, run on docker by following

README_ja.md Outdated
@@ -87,7 +87,9 @@ docker compose down
`mix test.watch` を導入しており,ソースコードの編集時毎に,単体テスト `mix test` やコード整形 `mix format` を自動実行できます.

```
mix test.watch
$ mix test.watch
# docker で動作させるには
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# docker で動作させるには
# または docker で動作させるには

@takasehideki
Copy link
Member

↑些細なものなのでこちらで対応して merge します!

@takasehideki takasehideki merged commit 240547b into main Oct 4, 2022
@takasehideki takasehideki deleted the hotfix-update_readme-pojiro branch October 4, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants