Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DASHING support from c source #189

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Remove DASHING support from c source #189

merged 1 commit into from
Oct 25, 2022

Conversation

pojiro
Copy link
Contributor

@pojiro pojiro commented Oct 25, 2022

This closes #187.

@pojiro pojiro changed the title Remove DASHING support from c srouce Remove DASHING support from c sources Oct 25, 2022
@pojiro pojiro changed the title Remove DASHING support from c sources Remove DASHING support from c source Oct 25, 2022
@pojiro pojiro marked this pull request as ready for review October 25, 2022 04:19
@takasehideki
Copy link
Member

/opt/ros/${ROS_DISTRO} 配下でヘッダファイルの格納されている rosidl_runtime_c/ がまた変わらないかが不安ですが，Humble では少なくとも変わっていないので，このままで良いかと思います．今後また変わったら（これを参照思案柄）条件分岐を考えることにします．

@takasehideki takasehideki merged commit 6908820 into main Oct 25, 2022
@takasehideki takasehideki deleted the hotfix-issue_187-pojiro branch October 25, 2022 04:26
@takasehideki takasehideki mentioned this pull request Sep 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takasehideki takasehideki takasehideki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DASHING の cソースの条件分岐を #185 マージ後に落とす
2 participants
@pojiro @takasehideki