Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.10.0 is developed!! #286

Merged
merged 145 commits into from
Mar 19, 2024
Merged

0.10.0 is developed!! #286

merged 145 commits into from
Mar 19, 2024

Conversation

pojiro
Copy link
Contributor

@pojiro pojiro commented Feb 22, 2024

アーキテクチャを変更した、 BREAKING CHANGE な version 0.10.0 の PR です。 v0.9.x 以前との互換性はありません。

マージ前 TODOs

@pojiro
Copy link
Contributor Author

pojiro commented Feb 23, 2024

@takasehideki

2024年03月中の本ブランチの main ブランチへのマージを目指して作業を進めてもよいでしょうか?
もし、上記がオーケーでしたら、 main の更新を一旦ストップしていただければと思います。

理由はコードの刷新はあるものの、 v0.9.2 までの CHANGELOG.md などの過去の履歴を取り込むようにするためです。
ご確認ご検討よろしくお願いいたします。

@takasehideki
Copy link
Member

takasehideki commented Feb 23, 2024

@pojiro TL;DR: はい!お願いしまっす!!

記録的に v0.9.3 を切っておくかぁと思ったところ,Dependabot たんをずっと無視していて auto PR も切れていたことに気づきました;;(
Credo のアップデートで "code-analysis" がエラーになることは認識していますが,コードを改善するかオプションいじるかを v0.9.3 向けに頑張る必要はないかなと思って保留にしました.v0.10.0 の際に残っていたら考えるでいいかと(RCLの事情で致し方ないやつなのでオプション変更になるかと)
https://github.com/rclex/rclex/actions/runs/8014896862/job/21894247450

@pojiro
Copy link
Contributor Author

pojiro commented Feb 23, 2024

@takasehideki 承知しました。それでは、 v0.9.3 に対してリベースして作業するようにします。一旦預かりますね。

0.9.x のファイルを継承
based 0.9.x ci_allver.yml
enif_get_string_length/4 は OTP-26 で追加されたので OTP-25 以前には存在しない
WHY: use PartitionSupervisor which introduced in Elixir 1.14

we use it for subscription callback
the error is following

```
lib/mix/tasks/rclex/gen/msgs.ex:1:callback_info_missing
Callback info about the Mix.Task behaviour is not available.
```
@pojiro pojiro marked this pull request as ready for review March 15, 2024 07:56
@pojiro
Copy link
Contributor Author

pojiro commented Mar 15, 2024

@takasehideki

CHANGELOG.md の update は最終的な作業ですのでお任せいたします。また、mix docs で生成されるユーザ API のドキュメント内容等問題なければ、他ドキュメントの修正および本ブランチのマージまでお願いいたします。

他何かありましたら何なりとご連絡下さい。

@takasehideki
Copy link
Member

ではいきまっす!!

@takasehideki takasehideki merged commit 1759b33 into main Mar 19, 2024
@takasehideki takasehideki deleted the 0.10.0-dev branch March 19, 2024 10:01
takasehideki added a commit that referenced this pull request Mar 19, 2024
**Full Changelog**: v0.9.3...v0.10.0

**Almost Everything has been breaking changed!!**

According to the knowledge acquired by our R&D experience to date, the internal structure and design of this library have been significantly revised.
The API specification has also been completely redesigned.
From these changes, it is appropriate to say that we have almost reimplemented this library scratch in #286, leading by the awesome alchemist @pojiro :D

It should be noted that the API in this release is not compatible with v0.9 or earlier, so please be careful when updating this library used in your applications.

We will investigate after this release whether existing [Issues](https://github.com/rclex/rclex/issues) have been resolved by this historical improvement.
@takasehideki takasehideki mentioned this pull request Mar 19, 2024
FelixPe pushed a commit to FelixPe/rclex that referenced this pull request Apr 23, 2024
**Full Changelog**: rclex/rclex@v0.9.3...v0.10.0

**Almost Everything has been breaking changed!!**

According to the knowledge acquired by our R&D experience to date, the internal structure and design of this library have been significantly revised.
The API specification has also been completely redesigned.
From these changes, it is appropriate to say that we have almost reimplemented this library scratch in rclex#286, leading by the awesome alchemist @pojiro :D

It should be noted that the API in this release is not compatible with v0.9 or earlier, so please be careful when updating this library used in your applications.

We will investigate after this release whether existing [Issues](https://github.com/rclex/rclex/issues) have been resolved by this historical improvement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants