Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve timing of connection tests #12

Merged
merged 8 commits into from
Jul 14, 2021
Merged

Improve timing of connection tests #12

merged 8 commits into from
Jul 14, 2021

Conversation

takasehideki
Copy link
Member

change sync method of pub and sub nodes.

  • pub node will start after sub node has created. This sync will be done by creating sub_ready.txt.
  • pub node will continue until the process of sub node finished. This sync will be done by creating sub_msg.txt.

NOTE: this may fix rclex/rclex#28

@takasehideki takasehideki merged commit 7fa3973 into main Jul 14, 2021
@takasehideki takasehideki mentioned this pull request Jul 14, 2021
Closed
@takasehideki takasehideki mentioned this pull request Jul 24, 2021
Merged
@takasehideki takasehideki deleted the improve_timing branch January 20, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test scrpit "simple_pubsub/rclcpp_to_rclex.sh" sometimes failed in GitHub Actions
1 participant
@takasehideki