Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a move command #35

Closed
ChrisSLT opened this issue Mar 2, 2015 · 4 comments
Closed

Implement a move command #35

ChrisSLT opened this issue Mar 2, 2015 · 4 comments
Milestone

Comments

@ChrisSLT
Copy link

ChrisSLT commented Mar 2, 2015

Part of keeping things in sync is moving files from one place to another via Drive. Could you implement a command that moves all files from one place to another. Basically, it copies them and then after verifies successful copy on receiving end, deletes on source end?

@ncw ncw added the enhancement label Mar 2, 2015
@ncw
Copy link
Member

ncw commented Mar 2, 2015

Nice idea - thanks.

I'm working on server side copies at the moment which this would fit in nicely with.

@ncw
Copy link
Member

ncw commented Aug 16, 2015

Tech design:

  • make new optional interfaces Mover and DirMover
    • Mover should have the same interface as Copy - not be on an object
  • make a new rclone command "move"
    • This will attempt to use DirMover if available and the destination doesn't exist
    • if not it will attempt to use Mover on each file
    • if that doesn't work it will copy then delete the source
      • copy will use Copier interface if available

FS

  • Drive: can implement Mover and DirMover this using this api see also go library will need to set Title and possible add and remove parents
  • S3 doesn't support moving/renaming objects
  • Swift doesn't support moving/renaming objects
  • GCS doesn't support moving/renaming objects - can't change object name with patch
  • Dropbox can implement Mover and DirMover api
  • Local - can implement both with rename

See also #99

@ncw ncw changed the title Implement a move command for all files in directory Implement a move command Aug 16, 2015
@ncw ncw added this to the v1.19 milestone Aug 16, 2015
@ncw ncw closed this as completed in 59ba8f2 Aug 28, 2015
@ncw
Copy link
Member

ncw commented Aug 28, 2015

@ChrisSLT thanks for the feature request! Let me know how you get on and open a new ticket if you find issues.

I've factored the server side move stuff out of this to #115

@ChrisSLT
Copy link
Author

Terrific!

On Fri, Aug 28, 2015 at 5:59 AM, Nick Craig-Wood notifications@github.com
wrote:

@ChrisSLT https://github.com/ChrisSLT thanks for the feature request!
Let me know how you get on and open a new ticket if you find issues.

I've factored the server side move stuff out of this to #115
#115


Reply to this email directly or view it on GitHub
#35 (comment).

347.708.6549

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants