Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta download links #3570

Closed
justusiv opened this issue Sep 24, 2019 · 3 comments
Closed

Beta download links #3570

justusiv opened this issue Sep 24, 2019 · 3 comments

Comments

@justusiv
Copy link

justusiv commented Sep 24, 2019

It appears the betas have changed how they are being done with numbering etc but i would still think the contains of the "beta" should have a new versions. If the latest beta is older then the last stable should it contain the stable version?
http://beta.rclone.org/rclone-beta-latest-windows-amd64.zip
contains
rclone-v1.49.0-096-gc41812fc-beta-windows-amd64

@ncw
Copy link
Member

ncw commented Sep 25, 2019

The beta releases (master branch) have all the changes in the v1.49.3 branch they are just numbered incorrectly. I backported fixes from master into the v1.49.3 branch.

It isn't quite as easy as you might think to change the beta base version to v1.49.3 as the v1.49.3 tag isn't on the master branch

I do have a fix for this in the works though!

@ncw ncw added this to the v1.50 milestone Sep 25, 2019
ncw added a commit that referenced this issue Sep 25, 2019
Prior to this beta releases would appear to be older than the point
release, eg v1.49.0-096-gc41812fc which was released after v1.49.3 and
contains all the patches from v1.49.3.
@ivandeex
Copy link
Member

@ncw

It isn't quite as easy as you might think to change the beta base version to v1.49.3 as the v1.49.3 tag isn't on the master branch

You can trick travis into building off-master tags like this https://github.com/ivandeex/rclone/blob/master/.travis.yml#L7:

branches:
  only:
    - master
    - /^v[012]/
...snip...
deploy:
  on:
    tags: true
    all_branches: true
...snip...

Github actions will need a special treatment though.

@ncw
Copy link
Member

ncw commented Sep 26, 2019

You can trick travis into building off-master tags like this

Building them isn't the problem, it is getting the correct version back into master...

I'll merge the fix for this in a moment!

@ncw ncw closed this as completed in 6750af6 Sep 26, 2019
ncw added a commit that referenced this issue Sep 29, 2019
Prior to this beta releases would appear to be older than the point
release, eg v1.49.0-096-gc41812fc which was released after v1.49.3 and
contains all the patches from v1.49.3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants