Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homebrew depreciation #4775

Closed
xaocon opened this issue Nov 15, 2020 · 7 comments · Fixed by #4782
Closed

Homebrew depreciation #4775

xaocon opened this issue Nov 15, 2020 · 7 comments · Fixed by #4782

Comments

@xaocon
Copy link

xaocon commented Nov 15, 2020

What is the problem you are having with rclone?

Homebrew installation is being depreciated

What is your rclone version (output from rclone version)

rclone v1.53.2-DEV

  • os/arch: darwin/amd64
  • go version: go1.15.3

Which OS you are using and how many bits (e.g. Windows 7, 64 bit)

Which cloud storage system are you using? (e.g. Google Drive)

The command you were trying to run (e.g. rclone copy /tmp remote:tmp)

A log from the command with the -vv flag (e.g. output from rclone -vv copy /tmp remote:tmp)

None of this other stuff applies to this issue but I read them.
I took a look for reports of this issue already but didn't see one. This seems to be a pretty new change too. The problem is related to the fact fuse is required. See Homebrew/homebrew-core@4f0402f for more details.

@ncw
Copy link
Member

ncw commented Nov 16, 2020

I put a comment on commit Homebrew/homebrew-core@4f0402f#commitcomment-44223361

Note that rclone runs fine without FUSE installed (it dynamically loads it if present), it just can't run rclone mount.

@darthShadow - do you want to follow up on this one since you know something about brew and updated the rclone recipe recently?

@darthShadow
Copy link
Member

Sure, will do.

I was planning to anyway setup a separate tap (if nobody else does it) so we can have the mount command even once they remove support for FUSE since we will get too many issues otherwise about the missing mount command.

@darthShadow
Copy link
Member

Once I do send the PR, we will have the binary not supporting the mount command. How do you want to handle that? Perhaps a separate build tag which can be used in Homebrew that prints out a message (on using mount) regarding the lack of mount support and to download the binary from the website if they want it?

@xaocon
Copy link
Author

xaocon commented Nov 16, 2020 via email

@ncw
Copy link
Member

ncw commented Nov 17, 2020

Once I do send the PR, we will have the binary not supporting the mount command. How do you want to handle that? Perhaps a separate build tag which can be used in Homebrew that prints out a message (on using mount) regarding the lack of mount support and to download the binary from the website if they want it?

That is a nice idea. So a brew build tag maybe?

@darthShadow
Copy link
Member

Yep, will send a PR in the next few days if that's fine?

darthShadow added a commit to darthShadow/rclone that referenced this issue Nov 17, 2020
binaries installed via Homebrew - Fixes rclone#4775

Signed-off-by: Anagh Kumar Baranwal <6824881+darthShadow@users.noreply.github.com>
darthShadow added a commit to darthShadow/rclone that referenced this issue Nov 17, 2020
… the

binaries installed via Homebrew - Fixes rclone#4775

Signed-off-by: Anagh Kumar Baranwal <6824881+darthShadow@users.noreply.github.com>
@xaocon
Copy link
Author

xaocon commented Nov 18, 2020

Seems like maybe I jumped the gun on this after reading the the comments on the depreciation. I think just updating the formula to remove the fuse dependency for build is the right way to go. No reason to keep the prebuilt binaries from using fuse if it's available. Still might be worth mentioning it in caveats.

darthShadow added a commit to darthShadow/rclone that referenced this issue Nov 21, 2020
… the

binaries installed via Homebrew - Fixes rclone#4775

Signed-off-by: Anagh Kumar Baranwal <6824881+darthShadow@users.noreply.github.com>
@ncw ncw closed this as completed in #4782 Nov 26, 2020
ncw pushed a commit that referenced this issue Nov 26, 2020
… the

binaries installed via Homebrew - Fixes #4775

Signed-off-by: Anagh Kumar Baranwal <6824881+darthShadow@users.noreply.github.com>
ncw pushed a commit that referenced this issue Jan 13, 2021
… the

binaries installed via Homebrew - Fixes #4775

Signed-off-by: Anagh Kumar Baranwal <6824881+darthShadow@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants