Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mfs limitation ftp remote #4774

Merged
merged 5 commits into from Nov 23, 2020
Merged

mfs limitation ftp remote #4774

merged 5 commits into from Nov 23, 2020

Conversation

edwardxml
Copy link
Contributor

@edwardxml edwardxml commented Nov 15, 2020

Limitation consistent with rclone about remote: and mentioned in the rclone forum

What is the purpose of this change?

Reflect issue from forum in rclone documentation

Was the change discussed in an issue or in the forum before?

https://forum.rclone.org/t/rclone-union-mfs-most-free-space-not-working-for-ftp/20346

Checklist

  • [ x] I have read the contribution guidelines.
  • I have added tests for all changes in this PR if appropriate.
  • I have added documentation for the changes if appropriate.
  • All commit messages are in house style.
  • [x ] I'm done, this Pull Request is ready for review :-)

Limitation consistent with rclone about remote: and mentioned in the rclone forum

https://forum.rclone.org/t/rclone-union-mfs-most-free-space-not-working-for-ftp/20346
@edwardxml edwardxml changed the title mfs limitation whan ftp remote mfs limitation ftp remote Nov 15, 2020
Copy link
Member

@ncw ncw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment inline :-)

Thank you!

docs/content/ftp.md Outdated Show resolved Hide resolved
Modify to take account of @ncw comments 16/11/20 - more broadly consider impact of not supporting about, not just mfs in union
Remove some 'some' repetition and explain fuller consequences of lacking about capability
@edwardxml
Copy link
Contributor Author

edwardxml commented Nov 16, 2020

Thanks, that makes more sense.

Modified ftp.md to make the more general points re 'about' capability. Had been foxed by the OP on https://forum.rclone.org/t/rclone-union-mfs-most-free-space-not-working-for-ftp/20346 suggesting rclone about worked for him (def doesn't on my vsftpd).

Also reflected same changes in overview.md and removed repeated 'some'.

@ncw
Copy link
Member

ncw commented Nov 23, 2020

That looks great now - will merge - thank you :-)

@ncw ncw merged commit fb001b6 into rclone:master Nov 23, 2020
edwardxml added a commit to edwardxml/rclone that referenced this pull request Nov 25, 2020
Rclone about docs

Purpose:
Create a full loop of documentation for rclone about, backends overview and individual backend pages.

Discussion:
rclone#4774 relates

Previously requested, in part, under ref rclone#4801

Notes:
Introduce a tentative draft see-link format the end of sections to try rather than lots of in-para links.

Update about.go incl link to list of backends not supporting about.

In list of backends not supporting about, include link to about command reference.

I appreciate there may be decisions to make going forward about whether command links should be code formatted, and using proper pretty url links, but I have fudged that for now.

Update backend pages that do not support about with wording used previously for ftp - it is in passive voice but I can live with it. (my own wording and fault). The note is applied to a limitations section. If one does not already exist it is created (even if there are other limitations with their own sections)
edwardxml added a commit to edwardxml/rclone that referenced this pull request Nov 26, 2020
Purpose:
Create a full loop of documentation for rclone about, backends overview
and individual backend pages.

Discussion:
rclone#4774 relates

Previously pull was requested, in part, under ref
rclone#4801

Notes:
Introduce a tentative draft see-link format the end of sections to try
rather than lots of in-para links.

Update about.go incl link to list of backends not supporting about.

In list of backends not supporting about, include link to about command
reference.

I appreciate there may be decisions to make going forward about whether
command links should be code formatted, and using proper pretty url
links, but I have fudged that for now.

Update backend pages that do not support about with wording used
previously for ftp - it is in passive voice but I can live with it. (my
own wording and fault). The note is applied to a limitations section. If
one does not already exist it is created (even if there are other
limitations with their own sections)
@edwardxml edwardxml mentioned this pull request Nov 26, 2020
3 tasks
ncw pushed a commit that referenced this pull request Nov 27, 2020
Create a full loop of documentation for rclone about, backends overview
and individual backend pages.

Discussion:
#4774 relates

Previously pull was requested, in part, under ref
#4801

Notes:
Introduce a tentative draft see-link format the end of sections to try
rather than lots of in-para links.

Update about.go incl link to list of backends not supporting about.

In list of backends not supporting about, include link to about command
reference.

I appreciate there may be decisions to make going forward about whether
command links should be code formatted, and using proper pretty url
links, but I have fudged that for now.

Update backend pages that do not support about with wording used
previously for ftp - it is in passive voice but I can live with it. (my
own wording and fault). The note is applied to a limitations section. If
one does not already exist it is created (even if there are other
limitations with their own sections)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants