Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing from Source: AIX support #6344

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

MFriedmann
Copy link

@MFriedmann MFriedmann commented Jul 26, 2022

What is the purpose of this change?

Added aix build tags to allow compiling rclone on IBM AIX systems.
Excluded ncdu command since atotto/clipboard#65 is not yet merged.
Please note: AIX does not have FUSE support (mount not possible).

Was the change discussed in an issue or in the forum before?

https://forum.rclone.org/t/rclone-build-on-aix-7-2

Checklist

  • I have read the contribution guidelines.
  • [n/a] I have added tests for all changes in this PR if appropriate.
  • [n/a] I have added documentation for the changes if appropriate.
  • [n/a] All commit messages are in house style.
  • I'm done, this Pull Request is ready for review :-)

Copy link
Member

@ncw ncw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm to merge this then we need to make sure it stays compiling for aix...

The easiest way to ensure this is to add the AIX GOOS/GOARCH pair here

var osarches = []string{

Its then a very small step to make it appear on the downloads page

| Arch-OS | Windows | macOS | Linux | .deb | .rpm | FreeBSD | NetBSD | OpenBSD | Plan9 | Solaris |

So, what do you think - should AIX be an official supported download?

cmd/ncdu/ncdu.go Outdated
//go:build !plan9 && !js
// +build !plan9,!js
//go:build !plan9 && !js && !aix
// +build !plan9,!js, !aix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has an extra space!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed that (was a typo).

@MFriedmann
Copy link
Author

If I'm to merge this then we need to make sure it stays compiling for aix...

The easiest way to ensure this is to add the AIX GOOS/GOARCH pair here

var osarches = []string{

Its then a very small step to make it appear on the downloads page

| Arch-OS | Windows | macOS | Linux | .deb | .rpm | FreeBSD | NetBSD | OpenBSD | Plan9 | Solaris |

So, what do you think - should AIX be an official supported download?

I would love to see AIX in the list for supported OSes. added aix/ppc64 to cross-compile.go

About being sure that it keeps compiling for AIX:
I can offer my help. However, I am not sure how many users actually want to use rclone with AIX since mounting will not work.

@sshtx
Copy link

sshtx commented Jan 5, 2023

So, what do you think - should AIX be an official supported download?

Yes please!

About being sure that it keeps compiling for AIX: I can offer my help. However, I am not sure how many users actually want to use rclone with AIX since mounting will not work.

I for one wish that it was.

Copy link
Member

@ncw ncw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase on master to fix the lint problems?

@@ -76,6 +76,7 @@ var osarches = []string{
"plan9/amd64",
"solaris/amd64",
"js/wasm",
"aix/ppc64"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line needs a comma on the end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants