Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3: Add Liara LOS to provider list #6516

Merged
merged 6 commits into from Dec 6, 2022

Conversation

vashian
Copy link
Contributor

@vashian vashian commented Oct 25, 2022

What is the purpose of this change?

Was the change discussed in an issue or in the forum before?

Checklist

  • I have read the contribution guidelines.
  • I have added tests for all changes in this PR if appropriate.
  • I have added documentation for the changes if appropriate.
  • All commit messages are in house style.
  • I'm done, this Pull Request is ready for review :-)

@vashian
Copy link
Contributor Author

vashian commented Oct 25, 2022

@ncw Liara Object Storage (LOS) is a cloud object storage service and is compatible with S3.

docs/content/_index.md Outdated Show resolved Hide resolved
docs/content/s3.md Outdated Show resolved Hide resolved
docs/content/s3.md Outdated Show resolved Hide resolved
Copy link
Member

@ncw ncw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you drop the changes to the autogenerated part of s3.md

I will merge after that - thank you :-)

@vashian
Copy link
Contributor Author

vashian commented Nov 11, 2022

Using the new URL liara.ir/landing/object-storage
Now it's human-readable without any encoded character.

Also, drop the changes from autogenerated options part.

@vashian vashian requested a review from ncw November 11, 2022 08:03
@vashian
Copy link
Contributor Author

vashian commented Nov 25, 2022

@ncw Unfortunately I haven't heard from you in a while. Could you please tell me what went wrong?

@ncw
Copy link
Member

ncw commented Nov 25, 2022

@vashian sorry, I'm waiting for an update from you to remove the auto generated content from s3.md - otherwise your PR looks fine. So remove all the changes in s3.md between

{{< rem autogenerated options start" - DO NOT EDIT - instead edit fs.RegInfo in backend/s3/s3.go then run make backenddocs" >}}

and

{{< rem autogenerated options stop >}}

These will be put in as part of the release process - I prefer not to add them at this point.

Thank you

@vashian
Copy link
Contributor Author

vashian commented Nov 26, 2022

@vashian sorry, I'm waiting for an update from you to remove the auto generated content from s3.md - otherwise your PR looks fine. So remove all the changes in s3.md between

{{< rem autogenerated options start" - DO NOT EDIT - instead edit fs.RegInfo in backend/s3/s3.go then run make backenddocs" >}}

and

{{< rem autogenerated options stop >}}

These will be put in as part of the release process - I prefer not to add them at this point.

Thank you

@ncw I appreciate it. Thank you for your time.

@ncw ncw added this to the v1.62 milestone Dec 5, 2022
Copy link
Member

@ncw ncw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great - I'll merge now - thank you :-)

@ncw ncw merged commit 0a8b1fe into rclone:master Dec 6, 2022
@ncw ncw modified the milestones: v1.62, v1.61 Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants