Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypt: adding an option to set a custom_suffix #6392 #6958

Merged
merged 3 commits into from Apr 20, 2023
Merged

crypt: adding an option to set a custom_suffix #6392 #6958

merged 3 commits into from Apr 20, 2023

Conversation

jladbrook
Copy link
Contributor

What is the purpose of this change?

Adds an additional option when encrypting files allowing for a custom suffix.

Was the change discussed in an issue or in the forum before?

#6932

Checklist

  • I have read the contribution guidelines.
  • I have added tests for all changes in this PR if appropriate.
  • I have added documentation for the changes if appropriate.
  • All commit messages are in house style.
  • I'm done, this Pull Request is ready for review :-)

ncw
ncw reviewed Apr 19, 2023
View reviewed changes
Copy link
Member

@ncw ncw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is looking very nice.

I put a few suggestions inline.

backend/crypt/crypt.go Outdated Show resolved Hide resolved
backend/crypt/crypt.go Outdated Show resolved Hide resolved
backend/crypt/crypt.go Outdated Show resolved Hide resolved
backend/crypt/cipher.go Show resolved Hide resolved
ncw
ncw approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@ncw ncw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great now - thank you :-)

I'll just run the CI one last time and if it passes I'll merge

@ncw ncw merged commit 281a007 into rclone:master Apr 20, 2023
10 checks passed
@ncw
Copy link
Member

ncw commented Apr 20, 2023

Thank you :-)

@aniel300 aniel300 mentioned this pull request Oct 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncw ncw ncw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jladbrook @ncw