Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3: Add Leviia S3 Object Storage as provider #7134

Merged
merged 4 commits into from Jul 16, 2023
Merged

s3: Add Leviia S3 Object Storage as provider #7134

merged 4 commits into from Jul 16, 2023

Conversation

bbenjamin-sys
Copy link
Contributor

What is the purpose of this change?

Was the change discussed in an issue or in the forum before?

Checklist

  • I have read the contribution guidelines.
  • I have added tests for all changes in this PR if appropriate.
  • I have added documentation for the changes if appropriate.
  • All commit messages are in house style.
  • I'm done, this Pull Request is ready for review :-)

@ncw
Copy link
Member

ncw commented Jul 15, 2023

Did you run the rclone test suite to see if any quirks are needed?

cd backend/s3
go test -v -remote YourLevilaRemote:

Those tests need to pass - if they don't they paste the errors here and I'll help you interpret them.

@bbenjamin-sys
Copy link
Contributor Author

Hello Nick,

I give you my log file with the different tests.
I have test errors:

--- FAIL: TestIntegration (424.18s)
    --- FAIL: TestIntegration/FsMkdir (423.45s)
        --- FAIL: TestIntegration/FsMkdir/FsPutFiles (18.59s)
            --- FAIL: TestIntegration/FsMkdir/FsPutFiles/SetTier (0.13s)
FAIL
FAIL github.com/rclone/rclone/backend/s3 424.190s
=== RUN   TestIntegration/FsMkdir/FsPutFiles/SetTier
    fstests.go:1780:
                Error Trace:    /home/benjamin/rclone/fstest/fstests/fstests.go:1780
                Error:          Expected nil, but got: &s3err.RequestFailure{RequestFailure:(*awserr.requestError)(0xc000594540), hostID:""}
                Test:           TestIntegration/FsMkdir/FsPutFiles/SetTier
    fstests.go:1780:
                Error Trace:    /home/benjamin/rclone/fstest/fstests/fstests.go:1780
                Error:          Expected nil, but got: &s3err.RequestFailure{RequestFailure:(*awserr.requestError)(0xc000aa8e80), hostID:""}
                Test:           TestIntegration/FsMkdir/FsPutFiles/SetTier
    fstests.go:1782:
                Error Trace:    /home/benjamin/rclone/fstest/fstests/fstests.go:1782
                Error:          Not equal:
                                expected: "STANDARD_IA"
                                actual  : "STANDARD"

                                Diff:
                                --- Expected
                                +++ Actual
                                @@ -1 +1 @@
                                -STANDARD_IA
                                +STANDARD
                Test:           TestIntegration/FsMkdir/FsPutFiles/SetTier

leviia_test.txt

@bbenjamin-sys
Copy link
Contributor Author

I've edited the lint problem, simple tabulation, I'll check this difference between STANDARD and STANDARD_IA

Copy link
Member

@ncw ncw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I give you my log file with the different tests. I have test errors:

That error is fine. AWS names their tiers differently so we can ignore that error.

No other errors is very good :-)

I will run the CI then merge when it goes green.

@ncw ncw merged commit 119ccb2 into rclone:master Jul 16, 2023
10 checks passed
@ncw
Copy link
Member

ncw commented Jul 16, 2023

Thank you :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants