storj: performance improvement for large file uploads #7198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
storj.io/uplink v1.11.0 comes with an improved logic for uploading large files where file segments are uploaded concurrently instead of serially. This allows to fully utilize the network connection during the entire upload process. This change enable the new upload logic.
|
Result from integration tests against Storj: |
ncw
reviewed
Aug 3, 2023
| @@ -24,6 +24,7 @@ import ( | |||
|
|
|||
| "storj.io/uplink" | |||
| "storj.io/uplink/edge" | |||
| "storj.io/uplink/private/testuplink" | |||
There was a problem hiding this comment.
We are using something out of private? Maybe it should be public?
There was a problem hiding this comment.
This is not yet a public API. We will follow with a PR when it becomes a new API or the default behavior of storj.io/uplink. Until it is decided, we want to have this performance improvement in Rclone.
There was a problem hiding this comment.
OK. I'll merge as-is and you can send a follow up later.
There was a problem hiding this comment.
Here is follow up PR: #7305
|
Thank you :-) |
kaloyan-raev
added a commit
to kaloyan-raev/rclone
that referenced
this pull request
Sep 14, 2023
The improved upload logic is active by default in uplink v1.12.0, so the `testuplink.WithConcurrentSegmentUploadsDefaultConfig(ctx)` is not required anymore. See rclone#7198
5 tasks
ncw
pushed a commit
that referenced
this pull request
Sep 14, 2023
The improved upload logic is active by default in uplink v1.12.0, so the `testuplink.WithConcurrentSegmentUploadsDefaultConfig(ctx)` is not required anymore. See #7198
divyam234
pushed a commit
to divyam234/rclone
that referenced
this pull request
Sep 21, 2023
The improved upload logic is active by default in uplink v1.12.0, so the `testuplink.WithConcurrentSegmentUploadsDefaultConfig(ctx)` is not required anymore. See rclone#7198
ncw
pushed a commit
that referenced
this pull request
Oct 11, 2023
The improved upload logic is active by default in uplink v1.12.0, so the `testuplink.WithConcurrentSegmentUploadsDefaultConfig(ctx)` is not required anymore. See #7198
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
storj.io/uplink v1.11.0 has an improved logic for uploading large files where file segments are uploaded concurrently instead of serially. This allows to fully utilize the network connection during the entire upload process.
This change enables the new upload logic.
Was the change discussed in an issue or in the forum before?
No.
Checklist