Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install.sh: Clean up temp files in install script #7436

Merged
merged 1 commit into from Nov 20, 2023

Conversation

jahands
Copy link
Contributor

@jahands jahands commented Nov 20, 2023

What is the purpose of this change?

The install script at rclone.org/install.sh leaves temp files behind, which increases docker image size

Was the change discussed in an issue or in the forum before?

https://forum.rclone.org/t/install-sh-leaves-temp-files-around-inflating-docker-image-size/42940

Checklist

  • [ x] I have read the contribution guidelines.
  • [ n/a] I have added tests for all changes in this PR if appropriate.
  • [ n/a] I have added documentation for the changes if appropriate.
  • [x ] All commit messages are in house style.
  • [ x] I'm done, this Pull Request is ready for review :-)

Testing

Ran repro steps described in the forum thread:

Dockerfile:

FROM ubuntu:22.04
RUN apt-get update && apt-get install -y \
    curl zip \
    && rm -rf /var/lib/apt/lists/*
# This url contains the fix
RUN curl https://sh.uuid.rocks/install/rclone.sh | bash
docker build . -t rclone-example
dive rclone-example

With this change, we can see the temp files no longer inflate the docker image:
image

Copy link
Member

@ncw ncw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great - thank you!

@ncw ncw merged commit 20bd17f into rclone:master Nov 20, 2023
10 checks passed
@kapitainsky
Copy link
Contributor

@jahands

Have a look at this:

https://forum.rclone.org/t/rclone-v1-65-0-release/43100/17

I suspect it might have something to do with temp files cleanup change...

@jahands
Copy link
Contributor Author

jahands commented Nov 30, 2023

@kapitainsky odd! I will take a look this weekend

@jahands
Copy link
Contributor Author

jahands commented Dec 3, 2023

This was fixed here: 96f8b7c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants