fs rc: fixes incorrect Content-Type in HTTP API - fixes #7726 #7730
Conversation
fs/rc/rcserver/rcserver_test.go
Outdated
| tests := []testRun{ | ||
| { | ||
| Name: "Check Content-Type for JSON response", | ||
| URL: "rc/noop", // Assuming rc/noop returns JSON |
There was a problem hiding this comment.
You should be able to test the error case with rc/error - I'd suggest another test for that.
There was a problem hiding this comment.
Ok I added another test case for rc/error, good chance I did something in an odd way, lmk
KDreynolds
force-pushed
the
issue7726
branch
2 times, most recently
from
92b478d
to
efcdb43
Compare
fs/rc/rcserver/rcserver_test.go
Outdated
| testServer(t, tests, &opt) | ||
| } | ||
|
|
||
| func TestErrorContentTypeJSON(t *testing.T) { |
There was a problem hiding this comment.
Couldn't this test just be another test case in TestContentTypeJSON? I'm probably missing something as to why not...
If not I suggest you add a new feature to the testServer rather than duplicating it below. By that I mean add a new flag to testRun, set it in the test case, and use it to control the changes you need in testServer. That will make for much neater and more maintainable code.
fs/rc/rcserver/rcserver_test.go
Outdated
| // Simulate setting the error response in your actual handler | ||
| w.Header().Set("Content-Type", "application/json") | ||
| w.WriteHeader(tc.ExpectedStatus) | ||
| w.Write([]byte(tc.ExpectedJSON)) // This should be replaced with the actual error handling logic |
There was a problem hiding this comment.
The linter says this is missing an error check. w.Write returns a length and error if I remember correctly, so you'd check it something like this
_, err := w.Write(...)
require.NoError(t, err)
|
not exactly sure why the mac amd build failed. |
|
Thank you! Appreciate it! |
|
@KDreynolds I appreciate your contributions and I enjoy helping you with them, so keep them coming :-) |
|
Thank you, @KDreynolds and @ncw ! |
What is the purpose of this change?
Was the change discussed in an issue or in the forum before?
Checklist