Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/gitannex: Add config parameter synonyms for compat, update command documentation #7854

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

dmcardle
Copy link
Contributor

@dmcardle dmcardle commented May 18, 2024

What is the purpose of this change?

The main purpose is to simplify setup for users.

First, this PR adds aliases to the existing config parameters so users can use the same config names as https://github.com/git-annex-remote-rclone/git-annex-remote-rclone.

Secondly, this updates the command documentation.

  • It mentions that new versions of git-annex support type=rclone, so it's possible to skip the whole symlink business.
  • It drops duplicative description of config parameters, instead showing users how to use the --whatelse option of git annex initremote.
  • It rewrites setup steps for clarity, improves formatting, etc.

Was the change discussed in an issue or in the forum before?

Issue #7625

Checklist

  • I have read the contribution guidelines.
  • I have added tests for all changes in this PR if appropriate.
  • I have added documentation for the changes if appropriate.
  • All commit messages are in house style.
  • I'm done, this Pull Request is ready for review :-)

@dmcardle
Copy link
Contributor Author

@ncw, PTAL!

FYI, looks like there's an unrelated lint error in backend/googlephotos/.

@dmcardle
Copy link
Contributor Author

Friendly ping, @ncw :)

@dmcardle
Copy link
Contributor Author

@yarikoptic FYI, this should make porting over a little simpler — no need to manually translate each config name any more. I'd appreciate feedback on the markdown changes, too, if you have any thoughts!

I'd like to spell out in detail how to recover the configuration parameters originally used to make one's git-annex-remote-rclone remote, but I still haven't figured out exactly what command(s) would do that.

Mentioned the possibility of skipping the symlink for new versions of
git-annex. (Probably deserves a test once the new git-annex trickles
down to CI platforms.)

I stopped trying to explain each config parameter here. Rather, the doc
now shows the user how to ask git-annex to describe config parameters
with `--whatelse`.
Copy link
Member

@ncw ncw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me - thank you - sorry for the delay.

I'll merge it now.

If there is anything else you'd like to get in before the v1.67 release then now is the time as I'd like to do the release within a week or so.

@ncw ncw merged commit dac7f76 into rclone:master Jun 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants