Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Option to Optimize Exclusions, and restore their Affinity when restoring #40

Open
ghost opened this issue Mar 3, 2019 · 6 comments
Assignees
Labels
core Issue relates to _Core module enhancement
Projects
Milestone

Comments

@ghost
Copy link

ghost commented Mar 3, 2019

When I was trying to set the priority and core allocation for Steam.exe and looking at the debug console's commands it mentions "Exited. Restoring Previous State" after setting Steam.exe from turning it off/on and it resets back to the default settings. If I try to optimize Steam.exe while it is running the custom settings applied will work unless I turn off Steam.exe

Evidence for the 'exited' thing: https://imgur.com/a/GE3Xkp7

After restarting/deactivating Steam: https://imgur.com/a/MzNB5XX (notice that the 'previous state' sentence in the debug console is there).

While Steam is running: https://imgur.com/a/utApd3j (notice that the 'previous state' sentence in the debug console isn't there).

@rcmaehl
Copy link
Owner

rcmaehl commented Mar 5, 2019

So you're setting custom allocation for steam and it's getting reset to all cores after you restart steam or can you provide steps on how to reproduce?

@rcmaehl rcmaehl self-assigned this Mar 5, 2019
@ghost
Copy link
Author

ghost commented Mar 7, 2019

So you're setting custom allocation for steam and it's getting reset to all cores after you restart steam or can you provide steps on how to reproduce?

I am not that great at explaining on how to reproduce but let me try my best. What I do/did was:

1: Open up NotCPUCores
2: Put in Steam.exe into the process bar
3: Set the priority and core allocation
4: Click apply (open the debug console to see if you will get the 'restoring' message

alternate method:

1: Open up Steam (the app) and have it running
2: Open up NotCPUCores
3: Find the Steam.exe process in the debug console
4: One-click the steam process, and click the arrow on the right of the process bar/box
5: Set custom prioity and allocation
6: Close/restart Steam (Either NotCPUCores running in the background or not)
7: Open Steam again

But somehow if I try to set the affinity/priority of steam.exe via the notcpucores while steam is running and you go to the task manager and find the steam.exe process in the 'Details' and right click on steam.exe and click on the affinity or hover over priority and you should see the custom settings being applied are being shown and work, but if i restart steam.exe the custom settings will reset back to default state ('normal' priority and all cores being used) you can see for yourself by checking in the task manager. The same happens to TF2 too.

@rcmaehl
Copy link
Owner

rcmaehl commented Mar 10, 2019

NotCPUCores doesn't automatically reapply custom priority/allocation once a program is relaunched, but I can definitely add that option in the next release. Next release should allow optimizing multiple processes at once as well.

@ghost
Copy link
Author

ghost commented Mar 10, 2019

NotCPUCores doesn't automatically reapply custom priority/allocation once a program is relaunched, but I can definitely add that option in the next release. Next release should allow optimizing multiple processes at once as well.

Will you also try to make the automatic re-applying work after when you restart/shutoff computer, then launching the prioritized, allocated app?

@rcmaehl
Copy link
Owner

rcmaehl commented Mar 11, 2019

Will you also try to make the automatic re-applying work after when you restart/shutoff computer, then launching the prioritized, allocated app?

Yep, Auto-start, multiple process optimization, settings saving, and more are planned. Need to finish up the new UI first and iron out a lot of bugs that came with making the new UI.

@ThumpieBunnyEve
Copy link

+1 for the "resume prior saved process optimizations" at relaunch.

rcmaehl added a commit that referenced this issue May 5, 2019
rcmaehl added a commit that referenced this issue May 6, 2019
@rcmaehl rcmaehl added this to To do in 1.8.0.0 via automation May 6, 2019
@rcmaehl rcmaehl added this to the 1.8 milestone May 6, 2019
@rcmaehl rcmaehl changed the title "Restoring Previous State" bug; optimizations reset or do not save/work Add Option to Optimize Exclusions, and restore their Affinity when restoring May 6, 2019
rcmaehl added a commit that referenced this issue May 10, 2019
Continue on #43, #40, #9
Put Exclusions in an array
Add ability to sort Exclusions List
More Fixes for controls being enabled when they shouldn't be
Only Refresh the current tab to prevent locking up NCC for too long
rcmaehl added a commit that referenced this issue May 10, 2019
rcmaehl added a commit that referenced this issue May 7, 2020
2.0 will address:

#9
#26
#31
#40
#44
#55
#56
#57

2.0 will seperate the core optimizations from the GUI to allow each to be updated seperately.
@rcmaehl rcmaehl added the core Issue relates to _Core module label May 8, 2020
@rcmaehl rcmaehl mentioned this issue Oct 2, 2020
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issue relates to _Core module enhancement
Projects
1.8.0.0
  
To do
Development

No branches or pull requests

2 participants