Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: manage dependency version via workspace.dependencies #49

Open
WenyXu opened this issue May 16, 2023 · 3 comments
Open

Enhancement: manage dependency version via workspace.dependencies #49

WenyXu opened this issue May 16, 2023 · 3 comments

Comments

@WenyXu
Copy link
Contributor

WenyXu commented May 16, 2023

Considers managing dependencies version in root Cargo.toml.

i.g.,

# [PROJECT_DIR]/Cargo.toml
[workspace]
members = ["bar"]

[workspace.package]
version = "1.2.3"
authors = ["Nice Folks"]
description = "A short description of my package"
documentation = "https://example.com/bar"
# [PROJECT_DIR]/bar/Cargo.toml
[package]
name = "bar"
version.workspace = true
authors.workspace = true
description.workspace = true
documentation.workspace = true

We can utilize this to avoid dependency version conflicts in the sub-crates.

See also, https://doc.rust-lang.org/cargo/reference/workspaces.html#the-package-table

@equation314
Copy link
Member

After using this, do all crates need to have the same version?

@WenyXu
Copy link
Contributor Author

WenyXu commented May 17, 2023

After using this, do all crates need to have the same version?

No, it's configurable. If some crates try to use another version, keep setting a specific version instead of pkg.workspace = true.

@equation314
Copy link
Member

equation314 commented May 17, 2023

I haven't see the benefit of it, could you give a more detail example?

yuoo655 pushed a commit to yuoo655/arceos_net that referenced this issue Jun 1, 2024
fix: futex requeue error and implement futex key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants