enrollments panel progress #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… coordinator panel
… incomplete, temporary solution to authenticate coordinators
…ctionality for privelleged users.
…escope into wyatt-enrollments-panel
…per landing page, but it works.
…tors to edit coordinator enrollments and added a submit notification to the edit form.
…enrollment edit form.
bepvte
suggested changes
Oct 25, 2022
bepvte
reviewed
Oct 26, 2022
| @@ -8,42 +8,42 @@ | |||
| </div> | |||
| <div class="card-body"> | |||
| <form onsubmit="return alert('Changes Saved!');" method="post"> | |||
| <div class="form-row"> | |||
| <div class="form-group"> | |||
| <label for="lead-select">Is Project Lead:</label> | |||
| <select class="form-control" id="lead-select", name="lead" required> | |||
There was a problem hiding this comment.
The commas after the element ID are not valid html syntax
|
I went ahead and rebuilt a lot of the form to be more semantic (using checkboxes for true and false) with bootstrap classes that correctly style it. If you approve of these changes then I can go ahead and merge it. |
bepvte
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #146,
Adds ability to edit enrollments in any current semester to the coordinator page.
Users also get relevant grade information on their profile page.
Things missing:
Also fixes some terribly ugly code I wrote earlier.