Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logout button is broken #837

Closed
mbarton opened this issue Mar 11, 2024 · 3 comments · Fixed by #839
Closed

Logout button is broken #837

mbarton opened this issue Mar 11, 2024 · 3 comments · Fixed by #839
Assignees
Labels
bug Something isn't working

Comments

@mbarton
Copy link
Member

mbarton commented Mar 11, 2024

  1. Log in
  2. Click log out

Expected

You're logged out!

Actual

You're not! It shows a blank white page.

You can see a 405 in the dev tools:

Screenshot from 2024-03-11 10-54-10

This is because we automatically upgraded to a newer version of Django which removed logging out from a GET request as a security measure: https://docs.djangoproject.com/en/5.0/releases/4.1/#log-out-via-get

@eatyourpeas
Copy link
Member

I thought I fixed this?

@mbarton
Copy link
Member Author

mbarton commented Mar 11, 2024

Hmm it's still broken for me on development today. I saw you commented about it here #828 (review), maybe it's on a branch somewhere?

@eatyourpeas
Copy link
Member

I think this happened just before @pacharanero force pushed something so it is possible that change got lost/overwritten.
I think the easiest thing is if I create a branch off development now using this issue and fix and send you a PR?

@eatyourpeas eatyourpeas self-assigned this Mar 11, 2024
@eatyourpeas eatyourpeas added the bug Something isn't working label Mar 11, 2024
eatyourpeas added a commit that referenced this issue Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants