Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use std::pow, update README, roll minor version (closes #64) #65

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

eddelbuettel
Copy link
Collaborator

This corrects #64, and while at it, adds Ivan to the README and rolls the minor release.

We can probably just relabel this as is as 0.2.5 -- or is there something else worth sweeping up now?

ChangeLog Outdated Show resolved Hide resolved
@ilyaZar
Copy link
Member

ilyaZar commented Sep 8, 2021

Regarding version incrementing:

I have no idea how the standard, or this particular project policies are regarding incrementing. If it's common practice to increment in these cases, and it's not too small a change to justify an increment, sure, 0.2.5 sounds good!

@eddelbuettel
Copy link
Collaborator Author

Yes the only rule is that there are no rules.

CRAN lets us do "whatever". Adam and I are card-carrying members of the "GNU" generation where things like compilers, editors, and even Linux kernels -- or entire statistical languages and environments -- commonly go by "a.b.c". It did occur to me this morning this is as good a candidate for a "patch release 0.2.4.1" as ever -- but then I reminded myself that there is value in consistency.

But we could go either way. No strong feelings.

Copy link
Collaborator

@adamjohansen adamjohansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this.

@adamjohansen adamjohansen merged commit 6490021 into master Sep 9, 2021
@adamjohansen
Copy link
Collaborator

We have 0.2.4.1 in DESCRIPTION at present, which is fine with me and seems fairly logical -- although ending up with anything more convoluted (0.2.4.1-pl65, anybody?) might be overkill. But no strong feelings either way.

@eddelbuettel
Copy link
Collaborator Author

Ah yes but that 0.2.4.1 is really only temporary esp as there are now services autobuilding binaries (https://r-universe.dev) so it is preferable to make these distinct. (It's complicated, I think overall r-universe is helpful but not distinguishing more clearly between CRAN and "other builds is not ideal -- so I try to increment at GitHub too.)

I'll upload later todat as 0.2.5.

@eddelbuettel eddelbuettel deleted the bugfix/pow branch October 10, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants