Initialize three variable (closes #74) #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjohansen
approved these changes
Mar 21, 2023
There was a problem hiding this comment.
Looks good to me; the default constructor would initialise thus anyway; I can't envisage any unexpected consequences.
There was a problem hiding this comment.
Yeah -- when I first glanced at I feared that maybe I needed an explicit resize but it seems all good, and is that teeny weeny bit more explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #74, this addresses a (valid, as usual, if somewhat picky but we have come to trust compilers) issue raised by CRAN.
R CMD checkstill passes, doing it under r-devel shows that we need to also update URL which I'll add to this.This should all be fairly uncontroversial unless I am asleep at the wheel, and you already chimed in at #74. Lightning speed, team!