Skip to content

Commit

Permalink
Drop all=True in IPACertRevocation cert_show call
Browse files Browse the repository at this point in the history
This was causing a cache miss in the LDAPCache class. The
'*' + all default attributes was confusing the cache. We in fact
do not need all attributes so this is fine. This increases the
cache hits in cert.py from 7 to 24, reducing the number of
duplicate LDAP searches.

Related: freeipa#307

Signed-off-by: Rob Crittenden <rcritten@redhat.com>
  • Loading branch information
rcritten committed Nov 6, 2023
1 parent 271dd25 commit fbdba1a
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/ipahealthcheck/ipa/certs.py
Original file line number Diff line number Diff line change
Expand Up @@ -1348,8 +1348,7 @@ def check(self):

# Now we have the cert either way, check the recovation
try:
result = api.Command.cert_show(cert.serial_number,
all=True)
result = api.Command.cert_show(cert.serial_number)
except Exception as e:
yield Result(self, constants.ERROR,
key=id,
Expand Down

0 comments on commit fbdba1a

Please sign in to comment.