Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to ensure that the model exists method can be used #406

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

mbardelmeijer
Copy link
Contributor

Adds a (failing) test that the Model's exists method can be used in templates.

When #405 is merged, this test will succeed and prevent breakage in the future.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 59.86% when pulling fbd9ff7 on mbardelmeijer:test/get-attr-test-exists into a4faebb on rcrowe:master.

@coveralls
Copy link

coveralls commented Sep 18, 2020

Coverage Status

Coverage remained the same at 59.804% when pulling fbd9ff7 on mbardelmeijer:test/get-attr-test-exists into a4faebb on rcrowe:master.

@mbardelmeijer
Copy link
Contributor Author

@barryvdh poke for this and #405 🙈

We're currently running on the #405 branch but prefer to use a tagged version :)

@barryvdh barryvdh merged commit f0249fe into rcrowe:master Oct 14, 2020
@bytestream
Copy link
Contributor

@mbardelmeijer the additions in this PR are two characters too many 🤦 hah

Would you mind sending another so tests pass?

$ ./vendor/bin/phpcs --standard=PSR2 -p --ignore=./tests/storage/* --report=full --report-checkstyle=build/logs/checkstyle.xml src/ tests/
...............................W............................ 60 / 67 (90%)
.......
FILE: /home/travis/build/rcrowe/TwigBridge/tests/Node/GetAttrTest.php
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 2 WARNING(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
 50 | WARNING | Line exceeds 120 characters; contains 122 characters
 54 | WARNING | Line exceeds 120 characters; contains 122 characters
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------

The command "./vendor/bin/phpcs --standard=PSR2 -p --ignore=./tests/storage/* --report=full --report-checkstyle=build/logs/checkstyle.xml src/ tests/" exited with 1.

@mbardelmeijer
Copy link
Contributor Author

mbardelmeijer commented Oct 14, 2020

Hehe, what are the chances -- will submit a PR with that fixed.

@mbardelmeijer
Copy link
Contributor Author

See #408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants