Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Won't compile on AppEngine #67

Closed
rcrowley opened this issue Aug 3, 2014 · 3 comments
Closed

Won't compile on AppEngine #67

rcrowley opened this issue Aug 3, 2014 · 3 comments

Comments

@rcrowley
Copy link
Owner

rcrowley commented Aug 3, 2014

Per rcrowley/go-tigertonic#75, go-metrics won't compile on App Engine because it uses runtime.NumCgoCall, among probably other verboten variables.

@rcrowley
Copy link
Owner Author

rcrowley commented Aug 3, 2014

@pshevtsov, can you please verify whether this fixes the build issue on AppEngine?

@przmv
Copy link

przmv commented Aug 6, 2014

@rcrowley unfortunately the changes do not fix the build issue:

05:09 PM Error 422: --- begin server output ---
Compile failed:
2014/08/06 06:09:38 go-app-builder: build timing: 5×6g (668ms total), 8×gopack (284ms total), 0×6l (0 total)
2014/08/06 06:09:38 go-app-builder: failed running 6g: exit status 1

github.com/rcrowley/go-metrics/runtime.go:128: undefined: numCgoCall
--- end server output ---

Probably it would be better to use !appengine and appengine build constraints as it was described here http://blog.golang.org/the-app-engine-sdk-and-workspaces-gopath .

mvitorino added a commit to mvitorino/go-metrics that referenced this issue Oct 15, 2014
@mihasya
Copy link
Collaborator

mihasya commented Jul 4, 2015

This appears to be fixed by an already merged PR! More issues like this please!

@mihasya mihasya closed this as completed Jul 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants