Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Librato reporting for timers is broken #89

Closed
bww opened this issue Nov 4, 2014 · 2 comments
Closed

Librato reporting for timers is broken #89

bww opened this issue Nov 4, 2014 · 2 comments

Comments

@bww
Copy link

bww commented Nov 4, 2014

This commit appears to have broken reporting to Librato for timers (at least):
d4f1d62#diff-2a2c532f685bccc6e7eb27c6144a94caR11

From Librato support:

{"attributes":{"display_transform":"x/1000000000","display_units_short":"s"},"count":203896,"max":8.25364642e+08,"min":4.843613e+06,"name":"metric.timer.mean","period":5,"sum_squares":2.79663655195528e+25},
which gives the error (as you mentioned in email to Nik)
{"errors":{"params":{"sum":["is required"]}
I can confirm that this was not a change in API behavior.  If you have a way to actually specify the "sum" field (because it's required if you specify "count"), that should fix the problem.  Docs: http://dev.librato.com/v1/post/metrics "Gauge Specific Parameters"

Also, I'm fairly certain once that's fixed, you'd run into an error with the "4.843613e+06" notation.
@mihasya
Copy link
Collaborator

mihasya commented Nov 5, 2014

Howdy! This was reported a few days ago and I only now finally got around to fixing it today. PR #81 and this additional commit 14abde2 should resolve the issue.

I don't think we've seen an issue with the format before, but let me know if it comes up. Cheers!

@bww
Copy link
Author

bww commented Nov 5, 2014

Yep, that did it. Thanks!

The number format doesn't seem to be an issue. JSON numbers support E notation so I wouldn't expect it to be a problem.

@bww bww closed this as completed Nov 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants