Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sum in Histogram librato measurement #81

Merged
merged 1 commit into from
Nov 4, 2014

Conversation

albanpeignier
Copy link
Contributor

Gauge sum is required in librato API when count is present :

If count is set, then sum must also be set in order to calculate an average value for the recorded metric measurement.

from Gauge Specific Parameters

Without this attribute, the request is refused :

2014/10/12 16:59:54 ERROR sending metrics to librato Unable to post to Librato: 400 400 Bad Request {"errors":{"params":{"sum":["is required"],"name":"buffer.SizeHistory.hist"}}}

@mihasya
Copy link
Collaborator

mihasya commented Oct 12, 2014

Puzzling. I just added a histogram to a service a few days ago, have data in the dashboard, and no errors in the logs. However, the error appears to be very clear and corresponds to the docs.

Would you mind getting client.go to print out the exact payload being posted so I have something with which to ping the librato folks? Thanks!

@mihasya
Copy link
Collaborator

mihasya commented Nov 4, 2014

Sorry about the delay, confirming that this was broken by this commit d4f1d62 had to do a bit of git bisect to get to the bottom of it.

@mihasya
Copy link
Collaborator

mihasya commented Nov 4, 2014

Also requires a fix to Timer so let me merge this and push that one next.

mihasya added a commit that referenced this pull request Nov 4, 2014
Add Sum in Histogram librato measurement
@mihasya mihasya merged commit a0b40a8 into rcrowley:master Nov 4, 2014
@rcrowley
Copy link
Owner

rcrowley commented Nov 8, 2014

Herp derp, thanks @albanpeignier and @mihasya.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants