throw error if column is not available (#23)

Signed-off-by: rahul <rcsofttech85@gmail.com>
rcsofttech85 · Sep 18, 2023 · f42b83f · f42b83f
1 parent 8049fa9
commit f42b83f
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/src/CsvFileHandler.php b/src/CsvFileHandler.php
@@ -209,9 +209,13 @@ private function replaceKeywordInRow(array &$row, string $keyword, string $repla
      * @param string $keyword
      * @param string $replace
      * @return int
+     * @throws FileHandlerException
      */
     private function replaceKeywordInColumn(array &$row, string $column, string $keyword, string $replace): int
     {
+        if (!array_key_exists($column, $row)) {
+            throw new FileHandlerException("invalid column name");
+        }
         $count = 0;
 
         if ($keyword === $row[$column]) {

diff --git a/tests/unit/CsvFileHandlerTest.php b/tests/unit/CsvFileHandlerTest.php
@@ -37,6 +37,15 @@ protected function tearDown(): void
         $this->csvFileHandler = null;
     }
 
+    #[Test]
+    #[DataProvider("wrongColumnNameProvider")]
+    public function throwExceptionIfWrongColumnNameProvided(string $columnName): void
+    {
+        $this->expectException(FileHandlerException::class);
+        $this->expectExceptionMessage("invalid column name");
+        $this->csvFileHandler->findAndReplaceInCsv("movie.csv", "Twilight", "hello", $columnName);
+    }
+
 
     #[Test]
     public function findAndReplaceInCsvMethodShouldReplaceTextWithoutColumnOption(): void
@@ -202,4 +211,13 @@ public static function fileProvider(): iterable
         yield [$file2];
         yield [$file3];
     }
+
+    /**
+     * @return iterable<array<string>>
+     */
+    public static function wrongColumnNameProvider(): iterable
+    {
+        yield ["wrong"];
+        yield ["honey bee"];
+    }
 }