Added option to name registered easing method. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| jQuery.extend({ bez: function(encodedFuncName, coOrdArray) { | ||
| if (jQuery.isFunction(encodedFuncName)) { | ||
| coOrdArray = encodedFuncName; | ||
| encodedFuncName = 'bez_' + jQuery.makeArray(arguments).join('_').replace(/\./g, 'p'); |
There was a problem hiding this comment.
I'm not sure I understand this. Are you wanting to allow an optional argument to explicitly name an easing function?
There was a problem hiding this comment.
Exactly. That would help reuse of these easing functions, like the following:
// Register a material design easing function:
$.bez('material', [0.55, 0, 0.1, 1]);
// Use it later in code:
$('.foo').fadeOut(500, 'material');There was a problem hiding this comment.
Right, so isFunction should be isArray then?
There was a problem hiding this comment.
Ouch, I'm sorry. I'll fix this and force the commit on this branch of mine ;) I just made this improvement for a code of mine, and didn't crossed my mind to try it with the old way haha.
lucasconstantino
force-pushed
the
named-easings
branch
from
3361644
to
cd6da70
Compare
|
Thanks! |
rdallasgray
added a commit
that referenced
this pull request
Dec 11, 2014
Added option to name registered easing method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.