Fix #58: Do not share netty framing handler among channels

rdbc-io · Nov 22, 2016 · 9aa9f93 · 9aa9f93
1 parent eefafc9
commit 9aa9f93
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/rdbc-pgsql-playground/src/main/scala/io/rdbc/pgsql/playground/tests.scala b/rdbc-pgsql-playground/src/main/scala/io/rdbc/pgsql/playground/tests.scala
@@ -768,4 +768,16 @@ object ManyInsertTest extends App {
 
   }
 
+}
+
+object MultiConnTst extends App {
+
+  implicit val ec = ExecutionContext.global
+  implicit val timeout = FiniteDuration.apply(10, "seconds")
+
+  val fact = NettyPgConnectionFactory("localhost", 5432, "povder", "povder", "povder")
+
+  val f = (1 to 10).map(_ => fact.connection()).reduce((f1, f2) => f1.flatMap(_ => f2))
+  Await.ready(f, Duration.Inf)
+  println("conns open")
 }
diff --git a/...ansport-netty/src/main/scala/io/rdbc/pgsql/transport/netty/NettyPgConnectionFactory.scala b/...ansport-netty/src/main/scala/io/rdbc/pgsql/transport/netty/NettyPgConnectionFactory.scala
@@ -102,7 +102,7 @@ class NettyPgConnectionFactory protected(remoteAddr: SocketAddress,
   private implicit val actorSystem = ActorSystem("RdbcPgSystem") //TODO unique system name?, TODO configurable system
   private implicit val streamMaterializer = ActorMaterializer()
 
-  def connection(): Future[PgConnection] = { //TODO important - it looks like you can't have multiple connections at the same time :D
+  def connection(): Future[PgConnection] = {
 
     var conn: NettyPgConnection = null
     //TODO bossGroup, workerGroup - familarize yourself
@@ -167,7 +167,7 @@ class NettyPgConnectionFactory protected(remoteAddr: SocketAddress,
     }
   }
 
-  private val framingHandler: LengthFieldBasedFrameDecoder = {
+  private def framingHandler: LengthFieldBasedFrameDecoder = {
     val lengthFieldLength = 4
     new LengthFieldBasedFrameDecoder(
       Int.MaxValue, /* max frame length */