Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CallFile fails using Context instead of Action #8

Closed
JerryWorkman opened this issue Apr 3, 2015 · 5 comments
Closed

CallFile fails using Context instead of Action #8

JerryWorkman opened this issue Apr 3, 2015 · 5 comments

Comments

@JerryWorkman
Copy link

In callfile.py line 71 is_valid returns false when a Context is passed as Action

           if not isinstance(self.action, Action):
                   return False
@rdegges
Copy link
Owner

rdegges commented Apr 3, 2015

It's been a while since I've worked on this -- should it be:

if not (isinstance(self.action, Action) or isinstance(self.context, Context))
    return False

?

@JerryWorkman
Copy link
Author

Close... but self.context does not exist - this works:

if not (isinstance(self.action, Action) or isinstance(self.action,

Context)):
return false

On Fri, Apr 3, 2015 at 2:44 PM, Randall Degges notifications@github.com
wrote:

It's been a while since I've worked on this -- should it be:

if not (isinstance(self.action, Action) or isinstance(self.context, Context))
return False

?


Reply to this email directly or view it on GitHub
#8 (comment).

@rdegges
Copy link
Owner

rdegges commented Apr 4, 2015

Thanks, I'm going to work on this a bit later and get it sorted out. Been a longgg time since I hacked on this project, so going to clean up some of the old cruft while I'm at it.

@JerryWorkman
Copy link
Author

Works great with that small change. I just completed a python cgi script that allows my security system to call me when there is an issue. Thanks. Good work.

@rdegges rdegges closed this as completed in f6d366a Apr 5, 2015
@rdegges
Copy link
Owner

rdegges commented Apr 5, 2015

Just pushed this fix, and cut a new release. If you install the latest version this will work =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants