Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smart card state isn't properly reset causing connection problems #344

Open
CendioOssman opened this issue Sep 3, 2019 · 0 comments
Open
Labels

Comments

@CendioOssman
Copy link
Member

Our smart card code currently doesn't reset properly. There are two times when this is needed:

  • When asked by the server (when we get PAKID_CORE_SERVER_ANNOUNCE)
  • When the connection is dropped

This can cause all kinds of issues as there might be pending smart card operations that will finish later and try to send the response when it is no longer allowed. This could result in bad responses to the server, or the connection being dropped because we try to send data when it is not allowed.

One case where this is easily seen is when you get redirected on connect. You then often get:

Core(error): tcp_send(), gnutls_record_send() failed with -408: Cannot perform this action while handshake is in progress.

Which is caused by the smart card code trying to send a response while we are doing the TLS handshake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant