Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scard logon #258

Merged
merged 3 commits into from Apr 27, 2018
Merged

Fix scard logon #258

merged 3 commits into from Apr 27, 2018

Conversation

uglym8
Copy link
Member

@uglym8 uglym8 commented Apr 3, 2018

I suggest to apply a patch from devel-list (sf) to fix #257

@uglym8
Copy link
Member Author

uglym8 commented Apr 3, 2018

I can't verify this patch atm, so I rely on the user's report (#257) of the successful testing.

@uglym8
Copy link
Member Author

uglym8 commented Apr 5, 2018

Added 2 more commits:

  1. Enable PnP notification in SCardGetStatusChange
  2. Fix TS_SCardEstablishContext() implementation as the current approach causes Windows logon to fail detect smartcard reader insertion in a case when rdesktop was lauched without any attached readers and with enabled scard redirection (See Opened transaction after smart card authentication in windows #257)

@uglym8
Copy link
Member Author

uglym8 commented Apr 5, 2018

The initial reporter has just verified that these patches do indeed fix his issue (#257)

@uglym8 uglym8 added this to the rdesktop-1.8.4 milestone Apr 27, 2018
@uglym8 uglym8 merged commit 0f9e410 into rdesktop:master Apr 27, 2018
rkondratenko and others added 3 commits April 27, 2018 13:46
Current approach for TS_SCardEstablishContext() causes
Windows not to detect scard reader insertion in a case
when rdesktop was lauched without attached reader(s).

Thanks to demansong@gmail.com for the help to pinpoint this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opened transaction after smart card authentication in windows
2 participants