Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Raptor support for everything but XML #77

Closed
RubenVerborgh opened this issue Jul 9, 2017 · 12 comments
Closed

Remove Raptor support for everything but XML #77

RubenVerborgh opened this issue Jul 9, 2017 · 12 comments
Milestone

Comments

@RubenVerborgh
Copy link
Member

Serd is now supported for both parsing and serializing. We should probably not maintain two parsers, and only keep Raptor around for XML.

Discussed in #53.

@RubenVerborgh
Copy link
Member Author

Let's wait for #81 to fix this.

@LaurensRietveld
Copy link
Member

I propose to remove the serialization support for XML as well. That way we only have to support the serd serializer

@RubenVerborgh
Copy link
Member Author

Fine with we, but we do lose functionality though then (whereas we don't with removing Raptor). That said, seem even better to leave XML conversion to external tools.

@LaurensRietveld
Copy link
Member

Well, tbh I actually meant to remove raptor support for rdf serialization only, and keep it for the parsing stuff. But removing raptor completely is fine with me as well. Saves us one dependency to maintain, and rdf/xml is such a legacy format..

@LaurensRietveld
Copy link
Member

Can we say there is a consensus on removing raptor completely? (i.e. disgarding XML as input and output format) If so, then we might prepare a PR for this

@webdata
Copy link
Contributor

webdata commented Sep 21, 2017

Hi! I was talking to someone in SEMANTiCS from a company that integrates different data sources, and they are still using RDF/XML. Well, I am also fine with removing raptor, we can label the old raptor code somehow such that anyone can hack a bit to put it back if really needed.

@wouterbeek
Copy link
Contributor

@webdata If this feature is valuable to them, this company may be able to contribute the maintenance of the Raptor option to the hdt-cpp project? That would be a win-win.

@RubenVerborgh
Copy link
Member Author

Nah, we should just support piping from STDIN (#25) and then they should pipe from rapper.

@wouterbeek
Copy link
Contributor

@RubenVerborgh Thanks for the pointer, but this pull request has remained unmerged for well over a year. Maybe the aforementioned company can put their weight behind rebasing and merging this pull request?

@RubenVerborgh
Copy link
Member Author

I'm sure that @rubensworks is happy to take it up again. I propose to continue with the removal of Raptor.

@rubensworks
Copy link
Member

@RubenVerborgh I would have time to look into rebasing/rewriting #25. I'm just wondering if it is still necessary, as @MarioAriasGa has pointed out that piping can already be done on Mac and Linux.

Furthermore, #25 only adds a new method for streaming triples into BasicHDT, STDIN streaming would have to be implemented on top of that.

@LaurensRietveld
Copy link
Member

Raptor is removed as dep in the develop branch (see #98), so I'll just close this issue. The issue with not being able to pipe th rdf2hdt still seems to be unresolved, but let's discuss that in #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants