Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autotools #81

Closed
wants to merge 53 commits into from
Closed

Autotools #81

wants to merge 53 commits into from

Conversation

ptorrestr
Copy link
Contributor

Configure and compile with autotools #22

@mielvds
Copy link
Member

mielvds commented Aug 10, 2017

Thanks, this is huge! Looks good to me, but I'm no expert. I'd wait for @webdata, @MarioAriasGa and maybe @bendiken their approval

@LaurensRietveld
Copy link
Member

Thanks indeed. Tested this branch locally (following the procedure here https://github.com/ptorrestr/hdt-cpp-1/blob/autotools/.travis.yml#L47), and it seems to work just fine.

@LaurensRietveld
Copy link
Member

Ah, just noticed this PR probably has to be rebased to the develop branch

@LaurensRietveld
Copy link
Member

We rebased this branch on develop, and pushed it to an autotools branch (https://github.com/rdfhdt/hdt-cpp/tree/autotools).
@RubenVerborgh : could you move this branch to develop once you've released the current develop branch?

@RubenVerborgh
Copy link
Member

@LaurensRietveld I'm afraid another rebase will be necessary.

@LaurensRietveld
Copy link
Member

No problem, I'll rebase and move the branch to dev

@LaurensRietveld
Copy link
Member

I've rebase autotools again, and moved it to dev. Thanks again @ptorrestr !

@LaurensRietveld
Copy link
Member

Ah, one thing left to do btw is updating the compilation docs. We'll do so soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants