Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter ci of method TriplesPrivate::saveIndex not needed #89

Open
jmkeil opened this issue Jan 23, 2019 · 0 comments
Open

Parameter ci of method TriplesPrivate::saveIndex not needed #89

jmkeil opened this issue Jan 23, 2019 · 0 comments
Assignees
@mielvds
Labels
refactoring Results into cleaner, shorter or better code.

Comments

@jmkeil
Copy link

jmkeil commented Jan 23, 2019

I think, one could remove the parameter ci from TriplesPrivate::saveIndex as in the only implementation (BitmapTriples::saveIndex; TriplesList and TriplesListLong do not properly implement it) ControlInfo::clear will be called immediately. Therefore, it would be better to instantiate a new one in the method instead of manipulating a provided one.
@mielvds mielvds self-assigned this Apr 16, 2021
@mielvds mielvds added the refactoring Results into cleaner, shorter or better code. label Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mielvds mielvds

Labels
refactoring Results into cleaner, shorter or better code.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mielvds @jmkeil